Add a default for DagModel.default_view#10897
Merged
kaxil merged 1 commit intoapache:masterfrom Sep 15, 2020
Merged
Conversation
turbaszek
approved these changes
Sep 15, 2020
mik-laj
reviewed
Sep 15, 2020
Comment on lines
+1624
to
+1629
| def get_default_view(self): | ||
| """This is only there for backward compatible jinja2 templates""" | ||
| if self.default_view is None: | ||
| return conf.get('webserver', 'dag_default_view').lower() | ||
| else: | ||
| return self.default_view |
Member
There was a problem hiding this comment.
Suggested change
| def get_default_view(self): | |
| """This is only there for backward compatible jinja2 templates""" | |
| if self.default_view is None: | |
| return conf.get('webserver', 'dag_default_view').lower() | |
| else: | |
| return self.default_view | |
| @property | |
| def default_view(self): | |
| """This is only there for backward compatible jinja2 templates""" | |
| if self._default_view is None: | |
| return conf.get('webserver', 'dag_default_view').lower() | |
| else: | |
| return self._default_view | |
| @default_view.setter | |
| def default_view(self, value): | |
| self._default_view= value |
This way we won't have two similar public attributes of default_view property, get_default_view method.
Member
Author
There was a problem hiding this comment.
I kept it there for parity between Dag and DagModel, otherwise dag.html and dags.html might use or the other depending on if we are using Dag or DagModel
The other option is to create a Database migration to fill all the null values, WDYT? @mik-laj
Member
There was a problem hiding this comment.
Okey. Now I understand the whole change. It looks good.
mik-laj
approved these changes
Sep 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10283
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.