Skip to content

[WIP] sketch import error alert emails#10969

Closed
jaketf wants to merge 1 commit into
apache:masterfrom
jaketf:importErrorAlert
Closed

[WIP] sketch import error alert emails#10969
jaketf wants to merge 1 commit into
apache:masterfrom
jaketf:importErrorAlert

Conversation

@jaketf
Copy link
Copy Markdown
Contributor

@jaketf jaketf commented Sep 16, 2020

This PR is a conversation piece that came from pondering how to support import error alert emails in #10968.
This is a feature will be especially useful for admins who use ClusterPolicyViolation or those who have pesky folks that push bad DAGs cluttering the UI with notifications that should be triaged to the on-call w/o human intervention.

I believe that the import_errors is a sad place in the airflow codebase and now might be the time to refactor this.
I've left TODO comments with questions about how to best keep track of import_error emails we have sent (as to not spam the recipients with emails every scheduler loop).

It seems to me we can either keep history of import errors in the existing table or create a new table (e.g. import_error_history which has a bool field for email_sent) for this purpose.

cc: @mik-laj

@boring-cyborg boring-cyborg Bot added the area:Scheduler including HA (high availability) scheduler label Sep 16, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Nov 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 1, 2020
@stale stale Bot closed this Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Scheduler including HA (high availability) scheduler stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant