[WIP] sketch import error alert emails#10969
Closed
jaketf wants to merge 1 commit into
Closed
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a conversation piece that came from pondering how to support import error alert emails in #10968.
This is a feature will be especially useful for admins who use
ClusterPolicyViolationor those who have pesky folks that push bad DAGs cluttering the UI with notifications that should be triaged to the on-call w/o human intervention.I believe that the
import_errorsis a sad place in the airflow codebase and now might be the time to refactor this.I've left TODO comments with questions about how to best keep track of import_error emails we have sent (as to not spam the recipients with emails every scheduler loop).
It seems to me we can either keep history of import errors in the existing table or create a new table (e.g.
import_error_historywhich has a bool field for email_sent) for this purpose.cc: @mik-laj