Skip to content

Add configure_environment.sh to ./breeze --start-airflow #10971

Merged
potiuk merged 2 commits intoapache:masterfrom
francescomucio:master
Sep 16, 2020
Merged

Add configure_environment.sh to ./breeze --start-airflow #10971
potiuk merged 2 commits intoapache:masterfrom
francescomucio:master

Conversation

@francescomucio
Copy link
Copy Markdown
Contributor

With ./breeze --start-airflow it was not possible to use the dags stored in files/dags in the host machine because the AIRFLOW__CORE__DAGS_FOLDER environment variable was not set.

This was because scripts/in_container/configure_environment.sh was not executed. I have added a call to that script.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk merged commit c9f006b into apache:master Sep 16, 2020
@francescomucio
Copy link
Copy Markdown
Contributor Author

@mik-laj @potiuk thanks

ashb added a commit to astronomer/airflow that referenced this pull request Sep 16, 2020
@ashb
Copy link
Copy Markdown
Member

ashb commented Sep 16, 2020

@potiuk This didn't run CI for some reason -- so it failed on master (tabs was used for indentation). Could you look at why it didn't run please? (Or did it run and we merged it with failing tests?)

ashb added a commit that referenced this pull request Sep 16, 2020
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Sep 16, 2020

It did run it but it took some time. That's my fault really - I should have checked. the GA works in the way that until it starts all the checks, the "rebase&squash" button gets "green". This is also when or two checks succeed but the dependent one did not start yet.
So if there are many PRs in the queue and there is a delay in running jobs, the PR looks green even if the checks did not start yet.

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Sep 16, 2020

Created an inssue in Github Support : https://github.community/t/merge-button-green-with-jobs-not-started-in-github-actions/132604. Some likes are welcome :)

@ashb
Copy link
Copy Markdown
Member

ashb commented Sep 16, 2020

It did run it but it took some time. That's my fault really - I should have checked. the GA works in the way that until it starts all the checks, the "rebase&squash" button gets "green". This is also when or two checks succeed but the dependent one did not start yet.
So if there are many PRs in the queue and there is a delay in running jobs, the PR looks green even if the checks did not start yet.

Oh lovely. Makes sense how it happened now, thanks

@francescomucio
Copy link
Copy Markdown
Contributor Author

I can create a new PR to fix the formatting, will that be ok?

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Sep 16, 2020

Fixed already by Ash and Kaxil

@francescomucio
Copy link
Copy Markdown
Contributor Author

Oh, great, I didn't notice it. Thanks for fixing my error.

@potiuk potiuk added this to the Airflow 1.10.13 milestone Sep 25, 2020
potiuk pushed a commit that referenced this pull request Sep 25, 2020
RaviTezu pushed a commit to RaviTezu/airflow that referenced this pull request Oct 25, 2020
kaxil pushed a commit that referenced this pull request Nov 12, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants