Add Azure Data Factory hook

[flvndh]

Tackle #10995

[feluelle]

Thank you for all the tests @flvndh 👍 maybe you want to reduce the code but still keep the great coverage.. (see below)

[flvndh]

Thank you very much @feluelle for your review. I've applied all your comments. Note that parameterized seems to be incompatible with the latest versions of pytest. What do you think of using @pytest.mark.parametrize instead?

[feluelle]

Oh really? What error do you get? @pytest.mark.parametrize seems also to be a good option to use :)

[flvndh]

Tests are ignored and pytest emits a PytestCollectionWarning stating that "yield tests are no more collected".

How do you see the tests being refactored? I had in mind one test per method and use parameterization for the implicit and explicit factory cases. It Is also possible to go far and have one or two hyper parameterized functions but I think it will make the tests less readable. What do you think?

[feluelle]

I had in mind one test per method and use parameterization for the implicit and explicit factory cases.

I like this. 👍

It Is also possible to go far and have one or two hyper parameterized functions but I think it will make the tests less readable.

Readability is far more important than code duplication in my opinion. So I am in favor for one test per method.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[feluelle]

LGTM. Can you resolve the failing static checks, please? :)

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[kaxil]

Can you please rebase your PR on latest Master since we have applied Black and PyUpgrade on Master.

It will help if your squash your commits into single commit first so that there are less conflicts.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[kaxil]

@flvndh Can you please resolve the conflicts and ping us again, thanks

[mivinson]

@flvndh Can you please look at the merge conflicts? This is a very useful package that you have authored.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[flvndh]

@don4of4 Here you go 😀

[don4of4]

@kaxil Can we get this reviewed?

[kaxil]

Let's wait for the CI before we merge this

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[ShawnMcGough]

@kaxil - does this need to be re-queued or just waiting for the reviewers?

Thanks!

[kaxil]

The PR was some 200 commits behind of Master -- so rebased and pushed --let's wait for the CI results again

[ShawnMcGough]

@kaxil looks like a doc build failed and two MySQL/Py builds. 🤔

[kaxil]

@kaxil looks like a doc build failed and two MySQL/Py builds. 🤔

Transient failures :)