Skip to content

Comments

Increase typing coverage JDBC provider#11021

Merged
turbaszek merged 5 commits intoapache:masterfrom
SalAlba:sal-dev-jdbc
Sep 19, 2020
Merged

Increase typing coverage JDBC provider#11021
turbaszek merged 5 commits intoapache:masterfrom
SalAlba:sal-dev-jdbc

Conversation

@SalAlba
Copy link
Contributor

@SalAlba SalAlba commented Sep 18, 2020

This PR is about increasing typing coverage for the JDBC provider. Part of: #9708

CC: @turbaszek @mik-laj Can I ask for review?


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@SalAlba
Copy link
Contributor Author

SalAlba commented Sep 19, 2020

MP_DIR=$(mktemp -d); mypy --linecount-report ${MP_DIR} airflow/; cat "${MP_DIR}/linecount.txt" | grep providers | grep -v example_dags | awk '
$4 != 0 {
    split($5, a, ".");
    print 100.00 * ($3/$4), a[3]
}'| awk '
{ sum[$2] += $1; N[$2]++ } 
END { 
    for (key in sum) {
        avg = sum[key] / N[key];
        printf "%f %s\n", avg, key;
    } 
}' | sort -g

0,000000 dingding
0,000000 opsgenie
0,000000 presto
0,000000 qubole
0,000000 samba
0,000000 zendesk
16,666650 ssh
16,666667 oracle
16,666667 yandex
16,666700 odbc
21,428550 databricks
25,000000 exasol
75,000000 jdbc <<< ==== was 25,00 now 75,00
25,000000 singularity
25,000000 snowflake
27,380950 slack
27,964227 amazon
33,333333 sftp
46,153850 imap
50,733332 microsoft
66,761375 cncf
67,857150 salesforce
69,117976 google
71,250000 ftp
75,000000 postgres
83,333300 openfaas
87,500000 redis
87,921875 apache
88,333340 mysql
88,888900 papermill
96,875000 mongo
100,000000 celery
100,000000 cloudant
100,000000 datadog
100,000000 discord
100,000000 docker
100,000000 elasticsearch
100,000000 facebook
100,000000 grpc
100,000000 hashicorp
100,000000 http
100,000000 jenkins
100,000000 jira
100,000000 pagerduty
100,000000 segment
100,000000 sendgrid
100,000000 sqlite
100,000000 vertica

@turbaszek turbaszek merged commit 9dd8310 into apache:master Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants