Update initialize-database.rst#11109
Conversation
Remove ambiguity in the language as only MySQL and Postgres are supported backends.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
SQLite should be mentioned given it's important for development/testing purpose.
Almost all new users start with SQLite (e.g. to test if the installation/setting-up is working). It will be weird to exclude it here.
Edit: what I meant is to mention SQLite (and highlight it's primarily for development purpose), to ensure consistent information. Otherwise people having quick looking at this may have the confusion "SQLite is not supported".
potiuk
left a comment
There was a problem hiding this comment.
Approved with the "SQLite" modification
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
|
@potiuk I made some minor changes on top of your suggestion (add "as", and fix the trailing comma to period.) |
|
Awesome work, congrats on your first merged pull request! |
|
Thanks @jmfreeman for the contribution. Hope you are ok with the changes that @potiuk and I have made. |
|
Seems like one-sentence changes are those that gets the most scrutiny :) cool stuff! |
|
And we have a new contributor ;) @jmfreeman ... Looking forward to more contributions ! |
Remove ambiguity in the language as only MySQL and Postgres are supported backends.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.