Conversation
There was a problem hiding this comment.
I wonder if we should not display a separate link for each person.
There was a problem hiding this comment.
How do you think we should do this ? Also why not links, I am asking because everything else is a link 😅
There was a problem hiding this comment.
{% for owner in dag.owners.split(",") %}
<a class="label label-default"
href="?search={{ owner | trim }}"
style="margin: 3px;">
{{ owner | trim }}
</a>
{% endfor %}
What do you think aboiut it?
There was a problem hiding this comment.
Ah yes I think I understood the question wrong, this does make more sense
Sangarshanan
force-pushed
the
filter-owner
branch
from
4743a16 to
9fee878
Compare
mik-laj
left a comment
mik-laj
left a comment
There was a problem hiding this comment.
LGTM, I would love to hear feedback from @ryanahamilton .
|
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed! |
github-actions
bot
added
the
okay to merge
ryanahamilton
left a comment
ryanahamilton
left a comment
There was a problem hiding this comment.
One minuscule styling suggestion, but otherwise LGTM!
Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com>
4 participants
Filter DAGs by clicking on the dag owner
closes: #9102
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.