Skip to content

Conversation

@dimberman
Copy link
Contributor

A pod_template_file should be treated as a template not a steadfast
rule.

This PR ensures that users can override individual values set by the
pod_template_file s.t. the same file can be used for multiple tasks.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

A pod_template_file should be treated as a *template* not a steadfast
rule.

This PR ensures that users can override individual values set by the
pod_template_file s.t. the same file can be used for multiple tasks.
@boring-cyborg boring-cyborg bot added the k8s label Sep 26, 2020
@dimberman dimberman requested review from ashb and kaxil September 26, 2020 05:03
@potiuk potiuk merged commit a888198 into apache:master Sep 27, 2020
@kaxil kaxil deleted the kubernetes-pod-operator-override branch September 27, 2020 22:03
dimberman added a commit that referenced this pull request Sep 28, 2020
* Allow overrides for pod_template_file

A pod_template_file should be treated as a *template* not a steadfast
rule.

This PR ensures that users can override individual values set by the
pod_template_file s.t. the same file can be used for multiple tasks.

* fix podtemplatetest

* fix name

(cherry picked from commit a888198)
@paolaperaza paolaperaza added this to the Airflow 1.10.13 milestone Sep 28, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Sep 30, 2020
* Allow overrides for pod_template_file

A pod_template_file should be treated as a *template* not a steadfast
rule.

This PR ensures that users can override individual values set by the
pod_template_file s.t. the same file can be used for multiple tasks.

* fix podtemplatetest

* fix name

(cherry picked from commit a888198)
(cherry picked from commit 227007c)
potiuk pushed a commit that referenced this pull request Oct 3, 2020
* Allow overrides for pod_template_file

A pod_template_file should be treated as a *template* not a steadfast
rule.

This PR ensures that users can override individual values set by the
pod_template_file s.t. the same file can be used for multiple tasks.

* fix podtemplatetest

* fix name

(cherry picked from commit a888198)
rafaelpierre pushed a commit to rafaelpierre/airflow that referenced this pull request Oct 4, 2020
* Allow overrides for pod_template_file

A pod_template_file should be treated as a *template* not a steadfast
rule.

This PR ensures that users can override individual values set by the
pod_template_file s.t. the same file can be used for multiple tasks.

* fix podtemplatetest

* fix name

(cherry picked from commit a888198)
rafaelpierre pushed a commit to rafaelpierre/airflow that referenced this pull request Oct 4, 2020
rafaelpierre pushed a commit to rafaelpierre/airflow that referenced this pull request Oct 4, 2020
RaviTezu pushed a commit to RaviTezu/airflow that referenced this pull request Oct 25, 2020
* Allow overrides for pod_template_file

A pod_template_file should be treated as a *template* not a steadfast
rule.

This PR ensures that users can override individual values set by the
pod_template_file s.t. the same file can be used for multiple tasks.

* fix podtemplatetest

* fix name

(cherry picked from commit a888198)
kaxil pushed a commit that referenced this pull request Nov 12, 2020
* Allow overrides for pod_template_file

A pod_template_file should be treated as a *template* not a steadfast
rule.

This PR ensures that users can override individual values set by the
pod_template_file s.t. the same file can be used for multiple tasks.

* fix podtemplatetest

* fix name

(cherry picked from commit a888198)
@potiuk potiuk added the type:improvement Changelog: Improvements label Nov 14, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
* Allow overrides for pod_template_file

A pod_template_file should be treated as a *template* not a steadfast
rule.

This PR ensures that users can override individual values set by the
pod_template_file s.t. the same file can be used for multiple tasks.

* fix podtemplatetest

* fix name

(cherry picked from commit a888198)
@kaxil kaxil added provider:cncf-kubernetes Kubernetes (k8s) provider related issues and removed area:k8s labels Nov 18, 2020
@kaxil kaxil removed this from the Airflow 1.10.13 milestone Nov 26, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
* Allow overrides for pod_template_file

A pod_template_file should be treated as a *template* not a steadfast
rule.

This PR ensures that users can override individual values set by the
pod_template_file s.t. the same file can be used for multiple tasks.

* fix podtemplatetest

* fix name

(cherry picked from commit a888198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:cncf-kubernetes Kubernetes (k8s) provider related issues type:improvement Changelog: Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants