-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Allow overrides for pod_template_file #11162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
potiuk
merged 3 commits into
apache:master
from
astronomer:kubernetes-pod-operator-override
Sep 27, 2020
Merged
Allow overrides for pod_template_file #11162
potiuk
merged 3 commits into
apache:master
from
astronomer:kubernetes-pod-operator-override
Sep 27, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pod_template_file should be treated as a *template* not a steadfast rule. This PR ensures that users can override individual values set by the pod_template_file s.t. the same file can be used for multiple tasks.
potiuk
approved these changes
Sep 27, 2020
turbaszek
approved these changes
Sep 27, 2020
dimberman
added a commit
that referenced
this pull request
Sep 28, 2020
* Allow overrides for pod_template_file A pod_template_file should be treated as a *template* not a steadfast rule. This PR ensures that users can override individual values set by the pod_template_file s.t. the same file can be used for multiple tasks. * fix podtemplatetest * fix name (cherry picked from commit a888198)
dimberman
pushed a commit
that referenced
this pull request
Sep 28, 2020
dimberman
pushed a commit
that referenced
this pull request
Sep 28, 2020
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 30, 2020
* Allow overrides for pod_template_file A pod_template_file should be treated as a *template* not a steadfast rule. This PR ensures that users can override individual values set by the pod_template_file s.t. the same file can be used for multiple tasks. * fix podtemplatetest * fix name (cherry picked from commit a888198) (cherry picked from commit 227007c)
potiuk
pushed a commit
that referenced
this pull request
Oct 3, 2020
* Allow overrides for pod_template_file A pod_template_file should be treated as a *template* not a steadfast rule. This PR ensures that users can override individual values set by the pod_template_file s.t. the same file can be used for multiple tasks. * fix podtemplatetest * fix name (cherry picked from commit a888198)
rafaelpierre
pushed a commit
to rafaelpierre/airflow
that referenced
this pull request
Oct 4, 2020
* Allow overrides for pod_template_file A pod_template_file should be treated as a *template* not a steadfast rule. This PR ensures that users can override individual values set by the pod_template_file s.t. the same file can be used for multiple tasks. * fix podtemplatetest * fix name (cherry picked from commit a888198)
rafaelpierre
pushed a commit
to rafaelpierre/airflow
that referenced
this pull request
Oct 4, 2020
rafaelpierre
pushed a commit
to rafaelpierre/airflow
that referenced
this pull request
Oct 4, 2020
RaviTezu
pushed a commit
to RaviTezu/airflow
that referenced
this pull request
Oct 25, 2020
* Allow overrides for pod_template_file A pod_template_file should be treated as a *template* not a steadfast rule. This PR ensures that users can override individual values set by the pod_template_file s.t. the same file can be used for multiple tasks. * fix podtemplatetest * fix name (cherry picked from commit a888198)
kaxil
pushed a commit
that referenced
this pull request
Nov 12, 2020
* Allow overrides for pod_template_file A pod_template_file should be treated as a *template* not a steadfast rule. This PR ensures that users can override individual values set by the pod_template_file s.t. the same file can be used for multiple tasks. * fix podtemplatetest * fix name (cherry picked from commit a888198)
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
* Allow overrides for pod_template_file A pod_template_file should be treated as a *template* not a steadfast rule. This PR ensures that users can override individual values set by the pod_template_file s.t. the same file can be used for multiple tasks. * fix podtemplatetest * fix name (cherry picked from commit a888198)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* Allow overrides for pod_template_file A pod_template_file should be treated as a *template* not a steadfast rule. This PR ensures that users can override individual values set by the pod_template_file s.t. the same file can be used for multiple tasks. * fix podtemplatetest * fix name (cherry picked from commit a888198)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
provider:cncf-kubernetes
Kubernetes (k8s) provider related issues
type:improvement
Changelog: Improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pod_template_file should be treated as a template not a steadfast
rule.
This PR ensures that users can override individual values set by the
pod_template_file s.t. the same file can be used for multiple tasks.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.