Add custom email backends.#1132
Merged
bolkedebruin merged 2 commits intoapache:masterfrom Mar 8, 2016
Merged
Conversation
jmcarp
force-pushed
the
custom-email-backend
branch
2 times, most recently
from
ccaa854 to
de75309
Compare
Contributor
|
@jmcarp if you dont mind adding the tests in this patch that would be great! |
Allow users to configure a custom email backend using the `EMAIL_BACKEND` configuration variable, which accepts a dotted import path. The backend defaults to the existing `send_email` helper, which is renamed to `send_email_smtp`. This can be used to send email without using SMTP, e.g. when sending mail via API. Note: this patch uses `importlib` instead of the deprecated `imp` module which is used elsewhere throughout `airflow`. [Resolves apache#1103]
jmcarp
force-pushed
the
custom-email-backend
branch
from
f97d34e to
b14da32
Compare
Contributor
Author
|
@bolkedebruin tests added! I see that the builds are failing in |
Contributor
|
Tests failing are unrelated to this PR. I need to fix that. Will merge this one. |
bolkedebruin
added a commit
that referenced
this pull request
Mar 8, 2016
Add custom email backends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to configure a custom email backend using the
EMAIL_BACKENDconfiguration variable, which accepts a dotted importpath. The backend defaults to the existing
send_emailhelper, which isrenamed to
send_email_smtp. This can be used to send email withoutusing SMTP, e.g. when sending mail via API.
Note: this patch uses
importlibinstead of the deprecatedimpmodulewhich is used elsewhere throughout
airflow.[Resolves #1103]