Skip to content

Improve Committer's guide docs #11338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Oct 8, 2020
Merged

Improve Committer's guide docs #11338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions CONTRIBUTING.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,10 +1181,9 @@ The following commit policy passed by a vote 8(binding FOR) to 0 against on May
and slightly modified and consensus reached in October 2020:

* Commits need a +1 vote from a committer who is not the author
* Furthermore, do not merge a PR that regresses linting or does not pass CI tests (unless we have
* Do not merge a PR that regresses linting or does not pass CI tests (unless we have
justification such as clearly transient error).
* When we do AIP voting, both PMC and committer +1s are considered as binding vote based on internal
PMC discussion.
* When we do AIP voting, both PMC and committer +1s are considered as binding vote.

Resources & Links
=================
Expand Down