Closed
Conversation
kaxil
approved these changes
Oct 8, 2020
Member
Author
|
I am looking into it. And why it has not failed before. I am still looking at it but at least that should fix it - it looks like when you have some earlier check setting the exit value while +e is in effect caused this one to exit with 1. So probably something started to leave the exit status "1" recently from earlier steps |
Member
Author
|
So it's really a side effect/bug present there for a while but not noticed before, but I am wondering why it just started to appear. looking at it. |
If some other check failed before, it could cause exit with wrong value
potiuk
force-pushed
the
fix-return-in-wrong-place
branch
from
2b4bcc0 to
1f2da2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If some other check failed before, it could cause exit with wrong
value
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.