Mount volumes and volumemounts into scheduler and workers#11426
Merged
dimberman merged 2 commits intoapache:masterfrom Oct 12, 2020
Merged
Mount volumes and volumemounts into scheduler and workers#11426dimberman merged 2 commits intoapache:masterfrom
dimberman merged 2 commits intoapache:masterfrom
Conversation
potiuk
requested changes
Oct 11, 2020
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
I think we need two things here:
- We need to have json schema for the values added
- Maybe this is the right time that we start reqiuiring unit tests for all the changes in chart ? The current test coverage is spotty at best, so maybe this is the right time we switch to "do it well" mode.
I am not talking about integration tests, I think those might be added later, but the unit tests would be great.
Contributor
Author
|
@potiuk I think requiring unit tests is good call. Will also be glad to add json stuff (though might need to wait until tomorrow) |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
Allows users to mount volumes to scheduler and workers
dimberman
force-pushed
the
volumes-helm
branch
from
81f75b8 to
4cfa180
Compare
Contributor
Author
|
@potiuk added tests and json |
potiuk
pushed a commit
that referenced
this pull request
Nov 15, 2020
* Mount arbitrary volumes and volumeMounts to scheduler and worker Allows users to mount volumes to scheduler and workers * tested (cherry picked from commit 045d68d)
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
* Mount arbitrary volumes and volumeMounts to scheduler and worker Allows users to mount volumes to scheduler and workers * tested (cherry picked from commit 045d68d)
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
* Mount arbitrary volumes and volumeMounts to scheduler and worker Allows users to mount volumes to scheduler and workers * tested (cherry picked from commit 045d68d)
kaxil
pushed a commit
that referenced
this pull request
Nov 18, 2020
* Mount arbitrary volumes and volumeMounts to scheduler and worker Allows users to mount volumes to scheduler and workers * tested (cherry picked from commit 045d68d)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* Mount arbitrary volumes and volumeMounts to scheduler and worker Allows users to mount volumes to scheduler and workers * tested (cherry picked from commit 045d68d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.