Rename (confusing) dag.sub_dag method to dag.partial_subset #11542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a method on the DAG class called `sub_dag()` that had nothing to do with Sub-DAGs or the SubDagOperator - It instead created a new "partial" dag that contained only a selected subset of tasks. To remove this confusion when seeing `dag.sub_dag()` used in code I have renamed this function, and included a compat shim in case anyone is using it outside of Airflow core.
kaxil
reviewed
Oct 15, 2020
kaxil
approved these changes
Oct 15, 2020
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
May 31, 2021
This is follow up of apache#11542 to all the missed places in the codebase.
kaxil
added a commit
that referenced
this pull request
Jun 1, 2021
This is follow up of #11542 to all the missed places in the codebase.
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Mar 10, 2022
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 4, 2022
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 10, 2022
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Aug 27, 2022
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
aglipska
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 7, 2022
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 13, 2024
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2024
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2024
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 1, 2025
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 22, 2025
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2025
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 16, 2025
This is follow up of apache/airflow#11542 to all the missed places in the codebase. GitOrigin-RevId: eb85c9d191e452aab596333b9e82d3a9e6428542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a method on the DAG class called
sub_dag()that had nothingto do with Sub-DAGs or the SubDagOperator - It instead created a new
"partial" dag that contained only a selected subset of tasks.
To remove this confusion when seeing
dag.sub_dag()used in code I haverenamed this function, and included a compat shim in case anyone is
using it outside of Airflow core.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.