Skip to content

Comments

_sanity_checks.sh re-login not needed on gnu commands install#11588

Merged
ashb merged 1 commit intoapache:masterfrom
alxdembo:sanity-check-reword-install-gnu-commands-guide
Oct 19, 2020
Merged

_sanity_checks.sh re-login not needed on gnu commands install#11588
ashb merged 1 commit intoapache:masterfrom
alxdembo:sanity-check-reword-install-gnu-commands-guide

Conversation

@alxdembo
Copy link
Contributor

Sourcing the profile file should be sufficient to update the PATH, re-login is not required.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 16, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@ashb ashb merged commit 73b0991 into apache:master Oct 19, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 19, 2020

Awesome work, congrats on your first merged pull request!

potiuk pushed a commit that referenced this pull request Nov 14, 2020
…-login is not required. (#11588)

(cherry picked from commit 73b0991)
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 14, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
…-login is not required. (#11588)

(cherry picked from commit 73b0991)
potiuk pushed a commit that referenced this pull request Nov 16, 2020
…-login is not required. (#11588)

(cherry picked from commit 73b0991)
kaxil pushed a commit that referenced this pull request Nov 18, 2020
…-login is not required. (#11588)

(cherry picked from commit 73b0991)
@alxdembo alxdembo deleted the sanity-check-reword-install-gnu-commands-guide branch December 12, 2020 20:11
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants