-
Notifications
You must be signed in to change notification settings - Fork 16.5k
update variables names in _in_container_script_init.sh #11750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
local variable switched to lower case
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. Though I think the env VAR is really a constant and should be read only
|
|
||
| # This should only be sourced from in_container directory! | ||
| IN_CONTAINER_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" | ||
| in_container_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| in_container_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" | |
| IN_CONTAINER_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" | |
| readonly IN_CONTAINER_DIR |
|
|
||
| # shellcheck source=scripts/in_container/_in_container_utils.sh | ||
| . "${IN_CONTAINER_DIR}/_in_container_utils.sh" | ||
| . "${in_container_dir}/_in_container_utils.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . "${in_container_dir}/_in_container_utils.sh" | |
| . "${IN_CONTAINER_DIR}/_in_container_utils.sh" |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
local variable switched to lower case
closes one of the items on :#10576
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.