Skip to content

Use LocalExecutor by default with tmux + Breeze#11791

Merged
potiuk merged 3 commits intoapache:masterfrom
astronomer:use-local-exec-by-default
Oct 24, 2020
Merged

Use LocalExecutor by default with tmux + Breeze#11791
potiuk merged 3 commits intoapache:masterfrom
astronomer:use-local-exec-by-default

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Oct 23, 2020

By default, it would be good to use LocalExecutor if not set in env file when started with breeze + tmux using ./breeze start-airflow


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. After the discussion I realised how wrong my assumptions were. I am going also to propose (in the thread that Ash started in the devlist) that we simply disallow sequential executor for postures/mysql. There is no reason IMHO to use sequential in Postgres/Mysql so changing behaviour for 2.0 to the way I assumed it work (local as default for PG/MySql and fail hard if you use sequential for them). This seems like a good idea I think :)

@potiuk potiuk merged commit 0218bcf into apache:master Oct 24, 2020
michalmisiewicz pushed a commit to michalmisiewicz/airflow that referenced this pull request Oct 30, 2020
* Use LocalExecutor by default with tmux + Breeze

* Update run_tmux.sh

* Update run_tmux.sh
szn pushed a commit to szn/airflow that referenced this pull request Nov 1, 2020
* Use LocalExecutor by default with tmux + Breeze

* Update run_tmux.sh

* Update run_tmux.sh
potiuk pushed a commit that referenced this pull request Nov 14, 2020
* Use LocalExecutor by default with tmux + Breeze

* Update run_tmux.sh

* Update run_tmux.sh

(cherry picked from commit 0218bcf)
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 14, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
* Use LocalExecutor by default with tmux + Breeze

* Update run_tmux.sh

* Update run_tmux.sh

(cherry picked from commit 0218bcf)
potiuk pushed a commit that referenced this pull request Nov 16, 2020
* Use LocalExecutor by default with tmux + Breeze

* Update run_tmux.sh

* Update run_tmux.sh

(cherry picked from commit 0218bcf)
kaxil added a commit that referenced this pull request Nov 18, 2020
* Use LocalExecutor by default with tmux + Breeze

* Update run_tmux.sh

* Update run_tmux.sh

(cherry picked from commit 0218bcf)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
* Use LocalExecutor by default with tmux + Breeze

* Update run_tmux.sh

* Update run_tmux.sh

(cherry picked from commit 0218bcf)
@kaxil kaxil deleted the use-local-exec-by-default branch December 31, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants