Fix locking issue stopping tasks running with SequentialExecutor#11797
Merged
kaxil merged 1 commit intoapache:masterfrom Oct 23, 2020
Merged
Fix locking issue stopping tasks running with SequentialExecutor#11797kaxil merged 1 commit intoapache:masterfrom
kaxil merged 1 commit intoapache:masterfrom
Conversation
Missing a commit means that the the row level lock was not released before `executor.heartbeat()` was called. This was only a problem for the SequentialExecutor, as all the other executors would continue running the scheduler code so the lock would be released shortly after tasks are sent to the executor anyway. (Where as SequentialExecutor doesn't return control until tasks have run!)
boring-cyborg
bot
added
the
area:Scheduler
kaxil
approved these changes
Oct 23, 2020
This was
linked to
issues
Oct 23, 2020
Closed
Member
|
Cool! |
Member
michalmisiewicz
pushed a commit
to michalmisiewicz/airflow
that referenced
this pull request
Oct 30, 2020
…che#11797) Missing a commit means that the the row level lock was not released before `executor.heartbeat()` was called. This was only a problem for the SequentialExecutor, as all the other executors would continue running the scheduler code so the lock would be released shortly after tasks are sent to the executor anyway. (Where as SequentialExecutor doesn't return control until tasks have run!)
szn
pushed a commit
to szn/airflow
that referenced
this pull request
Nov 1, 2020
…che#11797) Missing a commit means that the the row level lock was not released before `executor.heartbeat()` was called. This was only a problem for the SequentialExecutor, as all the other executors would continue running the scheduler code so the lock would be released shortly after tasks are sent to the executor anyway. (Where as SequentialExecutor doesn't return control until tasks have run!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing a commit means that the the row level lock was not released
before
executor.heartbeat()was called. This was only a problem forthe SequentialExecutor, as all the other executors would continue
running the scheduler code so the lock would be released shortly after
tasks are sent to the executor anyway. (Where as SequentialExecutor
doesn't return control until tasks have run!)
Fixes #11788 #11787
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.