Skip to content

Comments

Remove redundant builtins imports#11809

Merged
potiuk merged 1 commit intoapache:masterfrom
astronomer:remove-buitlins
Oct 24, 2020
Merged

Remove redundant builtins imports#11809
potiuk merged 1 commit intoapache:masterfrom
astronomer:remove-buitlins

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Oct 24, 2020

These imports are not needed in Python3

This will be enforced by PyUpgrade in #11447 -- which will be merged before 2.0 beta since it can cause conflicts for many PRs since it changes format to f-string that touches a large number of files


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

These imports are not needed in Python3
@kaxil kaxil requested review from dimberman and mik-laj October 24, 2020 02:44
@boring-cyborg boring-cyborg bot added the provider:amazon AWS/Amazon - related issues label Oct 24, 2020
@potiuk
Copy link
Member

potiuk commented Oct 24, 2020

Flaky test which I fixed in #11817 merging

@potiuk potiuk merged commit 3934ef2 into apache:master Oct 24, 2020
@kaxil kaxil deleted the remove-buitlins branch October 24, 2020 08:47
michalmisiewicz pushed a commit to michalmisiewicz/airflow that referenced this pull request Oct 30, 2020
These imports are not needed in Python3
szn pushed a commit to szn/airflow that referenced this pull request Nov 1, 2020
These imports are not needed in Python3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants