Adds documentation about the optimized PR workflow#12006
Conversation
potiuk
force-pushed
the
add-documentation-about-the-optimized-pr-workflow
branch
from
77b6765 to
f6eef4b
Compare
|
The Workflow run is cancelling this PR. It in earlier duplicate of 1029499 run. |
|
Promised documentation about the PR workflow. It was a bit emergency so I did not have time to add it before but here it is (cc: @TobKed). Any comments, improvements, spelling etc. are most welcome. Especially @ashb - since you had some doubts about whether the process is too heavy on the committers - maybe you can have some suggestions and improvement proposals here. I think PR form of the documentation is perfect if you have doubts and proposals to parts of the process. also once we sort out the self-hosted-runners security this will be a perfect place to add description about the architecture, deployments, and possibly modifications we've done to standard runners. Also @dimberman - you seemed to be in favour of the whole approach, so if you have any comments, proposals. I am happy to update it. Also the solution we came up with @TobKed is pretty flexible, so don't be shy when proposing improvements there. We can rather easily adapts some parts of it. |
potiuk
force-pushed
the
add-documentation-about-the-optimized-pr-workflow
branch
from
f6eef4b to
25e108f
Compare
|
(My doubts expressed in slack were due to seeing a thread, but not the non-threaded discussion that lead up to it) |
potiuk
force-pushed
the
add-documentation-about-the-optimized-pr-workflow
branch
from
25e108f to
1a1b5fd
Compare
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
All points updated. I changed "doc-only" (I think it was used in the past several times) to "no-code". I think it reflects better the actual scope of it. Happy to hear any proposal for a better name :)
|
Actually, this is a very good example of what's going on with the process here. This is the "no-code" change and it took literally 1m 25 seconds to pass all the necessary tests. :). I believe the direction we are going in is really good. |
github-actions
bot
added
the
okay to merge
|
The PR is ready to be merged. No tests are needed! |
We had a lot of problems recently about the queues in Github Actions. This documentations explains the motivation and approach we have taken for optimizing our PR workflow.
potiuk
force-pushed
the
add-documentation-about-the-optimized-pr-workflow
branch
from
1a1b5fd to
1728fbc
Compare
|
All resolved @kaxil :) |
|
Let's wait 2 minutes :D |
|
Done! Tests passed! |
We had a lot of problems recently about the queues in Github Actions. This documentations explains the motivation and approach we have taken for optimizing our PR workflow.
We had a lot of problems recently about the queues in Github Actions. This documentations explains the motivation and approach we have taken for optimizing our PR workflow. (cherry picked from commit d85a31f)
potiuk
added
the
type:misc/internal
We had a lot of problems recently about the queues in Github Actions. This documentations explains the motivation and approach we have taken for optimizing our PR workflow. (cherry picked from commit d85a31f)
We had a lot of problems recently about the queues in Github Actions. This documentations explains the motivation and approach we have taken for optimizing our PR workflow. (cherry picked from commit d85a31f)
We had a lot of problems recently about the queues in Github Actions. This documentations explains the motivation and approach we have taken for optimizing our PR workflow. (cherry picked from commit d85a31f)
We had a lot of problems recently about the queues in Github Actions. This documentations explains the motivation and approach we have taken for optimizing our PR workflow. (cherry picked from commit d85a31f)
3 participants
We had a lot of problems recently about the queues in Github
Actions. This documentations explains the motivation and approach
we have taken for optimizing our PR workflow.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.