Conversation
mik-laj
added
the
full tests needed
Member
Author
|
seems like docs-build isn't running for some reason |
potiuk
approved these changes
Nov 2, 2020
github-actions
bot
added
the
okay to merge
|
The PR is ready to be merged. No tests are needed! |
Merged
Member
|
This is likely because it was not rebased after the recent fix: #11834 |
Member
|
So it should not happen any more |
Member
|
But I am double-checking it |
Member
Author
|
Unlikely though as I rebased before I created this branch, but 🤷 |
Member
|
This one should fix it. It was indeed a bug in logic of selective check: #12038 It is simplified and more fine-grained now with separate image-build, docs-build, basic-static-checks -> they were all single condition before (basic-static-checks), but they should be separated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master is failing on Docs build: https://github.com/apache/airflow/runs/1341542937 after #12025 was merged
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.