Skip to content

Update faq.rst#12041

Merged
potiuk merged 4 commits intoapache:masterfrom
zigius:patch-1
Nov 2, 2020
Merged

Update faq.rst#12041
potiuk merged 4 commits intoapache:masterfrom
zigius:patch-1

Conversation

@zigius
Copy link
Contributor

@zigius zigius commented Nov 2, 2020


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk
Copy link
Member

potiuk commented Nov 2, 2020

@zigus would you be so kind and rebase it on top of the latest master please? I've just merged #12038 - we had a bug that disabled docs building in case of doc-only changed. So no docs were built in your PR, but when you rebase, they should be built!

@zigus
Copy link

zigus commented Nov 2, 2020

@zigus would you be so kind and rebase it on top of the latest master please? I've just merged #12038 - we had a bug that disabled docs building in case of doc-only changed. So no docs were built in your PR, but when you rebase, they should be built!

Hi @potiuk I think you wanted to mention @zigius not me :)

@potiuk
Copy link
Member

potiuk commented Nov 2, 2020

Hi @potiuk I think you wanted to mention @zigius not me :)

Ah yeah. Sorry :)

@zigius
Copy link
Contributor Author

zigius commented Nov 2, 2020

done. thanks @zigus

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And everything works as expected including docs build now :)

@potiuk potiuk merged commit 6ee6830 into apache:master Nov 2, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 2, 2020

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants