Fixes import of BaseOperator in dinging#12063
Merged
potiuk merged 1 commit intoapache:masterfrom Nov 3, 2020
Merged
Conversation
kaxil
approved these changes
Nov 3, 2020
|
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed! |
github-actions
bot
added
the
okay to merge
kaxil
requested changes
Nov 3, 2020
github-actions
bot
removed
the
okay to merge
turbaszek
approved these changes
Nov 3, 2020
The import was wrongly importing BaseOperator from bash_operator. Now it correctly imports it from models.
potiuk
force-pushed
the
fix-dinging-bad-import
branch
from
a3a3eaf to
5ec88b1
Compare
kaxil
approved these changes
Nov 3, 2020
|
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed! |
github-actions
bot
added
the
okay to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import was wrongly importing BaseOperator from bash_operator.
Now it correctly imports it from models.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.