Fixes problem with building a PROD image#12080
Merged
potiuk merged 1 commit intoapache:masterfrom Nov 4, 2020
Merged
Conversation
The change apache#12050 that aimed at automation of Docker images building in DockerHub had an undesired effect of overriding the production image tag with the CI one. This is fixed by this PR.
Member
Author
|
confirmed: https://github.com/potiuk/airflow/runs/1351642857?check_suite_focus=true - the right PROD image is built now in PROD . With the BUG, the CI image tag was was applied to PROD image instead of the PROD one. |
Member
Author
|
Confirmed: https://github.com/potiuk/airflow/runs/1351641739?check_suite_focus=true - > Wait for PROD image is GREEN |
TobKed
approved these changes
Nov 4, 2020
turbaszek
approved these changes
Nov 4, 2020
potiuk
added a commit
that referenced
this pull request
Nov 14, 2020
potiuk
added
the
type:misc/internal
potiuk
added a commit
that referenced
this pull request
Nov 16, 2020
potiuk
added a commit
that referenced
this pull request
Nov 16, 2020
kaxil
pushed a commit
that referenced
this pull request
Nov 18, 2020
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
The change apache#12050 that aimed at automation of Docker images building in DockerHub had an undesired effect of overriding the production image tag with the CI one. This is fixed by this PR. (cherry picked from commit d971c1c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change #12050 that aimed at automation of Docker images
building in DockerHub had an undesired effect of overriding the
production image tag with the CI one.
This is fixed by this PR.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.