Skip to content

Fix proper SHA in check preventing accidentally merging PR#12083

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:proper-sha-in-action-check
Nov 4, 2020
Merged

Fix proper SHA in check preventing accidentally merging PR#12083
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:proper-sha-in-action-check

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Nov 4, 2020

The SHA in check was not working for PRs from forks.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

The SHA in check was not working for PRs from forks.
@potiuk
Copy link
Member Author

potiuk commented Nov 4, 2020

cc: @TobKed

@potiuk potiuk requested review from ashb, kaxil and mik-laj November 4, 2020 10:36
@potiuk
Copy link
Member Author

potiuk commented Nov 4, 2020

@ashb -> this one will fix the protection on automated "full-test-needed" PRs :) The original SHA worked only on non-forked PRs.

@potiuk potiuk requested a review from turbaszek November 4, 2020 12:29
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Nov 4, 2020
@github-actions
Copy link

github-actions bot commented Nov 4, 2020

The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!

@potiuk potiuk merged commit d559da1 into apache:master Nov 4, 2020
@potiuk potiuk deleted the proper-sha-in-action-check branch November 4, 2020 12:51
potiuk added a commit that referenced this pull request Nov 14, 2020
The SHA in check was not working for PRs from forks.

(cherry picked from commit d559da1)
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 14, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020
potiuk added a commit that referenced this pull request Nov 16, 2020
The SHA in check was not working for PRs from forks.

(cherry picked from commit d559da1)
potiuk added a commit that referenced this pull request Nov 16, 2020
The SHA in check was not working for PRs from forks.

(cherry picked from commit d559da1)
kaxil pushed a commit that referenced this pull request Nov 18, 2020
The SHA in check was not working for PRs from forks.

(cherry picked from commit d559da1)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
)

The SHA in check was not working for PRs from forks.

(cherry picked from commit d559da1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools full tests needed We need to run full set of tests for this PR to merge type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants