Allow Connection Edit View to handle entries with NULL 'extra'#12149
Merged
XD-DENG merged 2 commits intoapache:masterfrom Nov 7, 2020
Merged
Allow Connection Edit View to handle entries with NULL 'extra'#12149XD-DENG merged 2 commits intoapache:masterfrom
XD-DENG merged 2 commits intoapache:masterfrom
Conversation
potiuk
approved these changes
Nov 7, 2020
Member
potiuk
left a comment
There was a problem hiding this comment.
That's cool. If possible to add a unit test, that would be great but it's ok like it is anyway
|
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed! |
Member
Author
kaxil
approved these changes
Nov 7, 2020
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
kaxil
approved these changes
Nov 7, 2020
Member
Author
Member
Author
|
It's the quarantined tests suite failing, and the main test cases are fine. So merging this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #12148 , a bug I observe in 2.0.0a2.
The root-cause is simple:
if the connection data is
{..., "extra": None}(which is common), thenform.data.get('extra', '{}')would returnNonerather than'{}', which causes error givenjson.loads()does not acceptNone.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.