KubernetesPodOperator: use randomized name to get the failure status#12171
Conversation
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
I think it would be great to add a unit test for this scenario (and possibly for success case as well ?)
|
That's great idea, Jarek, thanks! Just pushed two unit tests |
XD-DENG
added
the
full tests needed
|
Thanks for the fix. I just added full-test label and will re-trigger the CI |
|
Just one test failing : test_describes_pod_on_failure |
|
That may have been my suggested change that I added to this. |
|
Yup, that was my bad. |
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py
Outdated
Show resolved
Hide resolved
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
One test job failed with exitcode 137 in backfill tests. Merging. |
4 participants
This PR fixes the issue #12151, introduced by my commit here: #12117. It looks I didn't check the pod failure scenario, as none of my pods failed so far, sorry! 🙈
closes: #12151
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.