Skip to content

Comments

Add how-to Guide for Databricks operators#12175

Merged
potiuk merged 12 commits intoapache:masterfrom
sharad-vm:master
Nov 9, 2020
Merged

Add how-to Guide for Databricks operators#12175
potiuk merged 12 commits intoapache:masterfrom
sharad-vm:master

Conversation

@sharad-vm
Copy link
Contributor

@sharad-vm sharad-vm commented Nov 8, 2020


This PR adds a "how to" guide for databricks operators and has been opened to address this issue.

Close: #11916
^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 8, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Nov 8, 2020

Nice. Some static checks and docs building fails though.

@github-actions
Copy link

github-actions bot commented Nov 8, 2020

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@sharad-vm
Copy link
Contributor Author

@potiuk Thanks for taking a look. All the checks have passed now. If you could review it when you get a chance, that'd be great.
Thanks, Jarek!

@potiuk potiuk merged commit 7e0d08e into apache:master Nov 9, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 9, 2020

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Member

potiuk commented Nov 9, 2020

Thanks @sharad-vm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add how-to Guide for Databricks Operators

2 participants