Remove BaseDag and BaseDagBag classes#12195
Merged
ashb merged 1 commit intoapache:masterfrom Nov 9, 2020
Merged
Conversation
Since apache#7694 these haven't really be needed, but we hadn't removed them yet. No UPDATING.md note for this as I think it's extremely unlikely anyone was using this directly -- it's very much an implementation detail relating to DAG/SimpleDag.
ashb
added
full tests needed
ashb
added
priority:critical
kaxil
approved these changes
Nov 9, 2020
turbaszek
approved these changes
Nov 9, 2020
Member
Author
|
Most tests pass, a few 137 errorcode and slow CI. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #7694 these haven't really be needed, but we hadn't removed them
yet.
No UPDATING.md note for this as I think it's extremely unlikely anyone
was using this directly -- it's very much an implementation detail
relating to DAG/SimpleDag.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.