Remove redundant method in KubernetesExecutor#12317
Merged
turbaszek merged 1 commit intoapache:masterfrom Nov 14, 2020
Merged
Conversation
boring-cyborg
bot
added
area:Scheduler
potiuk
approved these changes
Nov 12, 2020
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Looks like indeed it's a remnant from some older version. @dimberman - do you agree?
github-actions
bot
added
the
full tests needed
|
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
turbaszek
force-pushed
the
remove-k8s-leftover
branch
2 times, most recently
from
d8f5705 to
55edb18
Compare
dimberman
approved these changes
Nov 13, 2020
The _inject_secrets method was invoked but it performed no action so it seems that we can remove it.
turbaszek
force-pushed
the
remove-k8s-leftover
branch
from
55edb18 to
062975c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _inject_secrets method was invoked but it performed no action so
it seems that we can remove it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.