Make airflow upgrade_check a command from a separate dist #12397
Conversation
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
By doing it this way we can add new features to upgrade_check, such as the adding a flag to make changes automatically, without having to release a new version of Airflow.
ashb
force-pushed
the
upgrade-check-from-external-dist
branch
from
f6ff9fa to
d9f4b72
Compare
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
@potiuk Test failed with "Local airflow CI image not available" which is not an error I've seen before. Possible we've got a bug in CI harness on v1-10-stable PRs now. Do you have time to look, or if not any ideas where I should start looking at? |
|
looking! |
|
Nope that 's not it. This message is perfectly fine there. It's a real flake8 error but I must have lost a fix not showing problems on pre-commits failing. I will make a PR shortly but in the meantime just run flake8 locally. |
|
Nope. I have not lost the messages - they are shown all right. I believe this is caused by https://github.com/apache/airflow/pull/12397/files#diff-2dfb149ecb4c1fe07a9c14f488a64326a8255a369d85fee621c4ecbd092a21acR2279 -> for some reason upgrade_check() is called when flake is executed likely and it causes system.exit() |
|
I also made #12402 chage to hide those messages by default. They are not useful for the user. |
😱 Flake is running code? THat's horrifying. I'll take a look. Ah no, it's that code, but not the exit. That's the error. But why didn't pre-commit/flake8 show it. |
|
or maybe simplu failing hard on |
|
Hmm. will take a look and try to reproduce |
|
I'm just rebuilding the image locally to elimiate that. |
|
(It's at times like this I wish pre-commit would have an option to output more debugging!) |
|
Hmmmm, now I've rebuilt it, pre-commit locally is showing me the error.... CURIOUS |
|
Yep. Same for me. strange :( |
By doing it this way we can add new features to upgrade_check, such as the adding a flag to make changes automatically, without having to release a new version of Airflow. (cherry picked from commit fb90c75)
By doing it this way we can add new features to upgrade_check, such as the adding a flag to make changes automatically, without having to release a new version of Airflow. (cherry picked from commit fb90c75)
3 participants
By doing it this way we can add new features to upgrade_check, such as
the adding a flag to make changes automatically, without having to
release a new version of Airflow.
I will next work on packaging up the existing checks in to a packageable format.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.