Skip to content

Improve UI file naming/patterns#12486

Merged
ryanahamilton merged 2 commits intoapache:masterfrom
astronomer:file_naming
Nov 19, 2020
Merged

Improve UI file naming/patterns#12486
ryanahamilton merged 2 commits intoapache:masterfrom
astronomer:file_naming

Conversation

@ryanahamilton
Copy link
Contributor

Files (sample) before:

static/
├─ css/
│  ├─ graph.css
│  ├─ main.css
├─ js/
│  ├─ base.js
│  ├─ graph.js
templates/
├─ airflow/
│  ├─ graph.html
│  ├─ master.html

Files (sample) after:

static/
├─ css/
│  ├─ graph.css
│  ├─ main.css
├─ js/
│  ├─ graph.js
│  ├─ main.js
templates/
├─ airflow/
│  ├─ graph.html
│  ├─ main.html

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Nov 19, 2020
@ryanahamilton ryanahamilton requested a review from ashb November 19, 2020 14:40
Copy link
Member

@ryw ryw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great commit @ryanahamilton

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 19, 2020
@github-actions
Copy link

The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!

@ryanahamilton ryanahamilton added this to the Airflow 2.0.0-beta4 milestone Nov 19, 2020
@ryanahamilton ryanahamilton merged commit bc01907 into apache:master Nov 19, 2020
@ryanahamilton ryanahamilton deleted the file_naming branch November 19, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants