Use html urls instead of onclick for dags view links.#12539
Merged
jmcarp merged 1 commit intoapache:masterfrom Nov 24, 2020
Merged
Use html urls instead of onclick for dags view links.#12539jmcarp merged 1 commit intoapache:masterfrom
jmcarp merged 1 commit intoapache:masterfrom
Conversation
boring-cyborg
bot
added
area:UI
ryanahamilton
requested changes
Nov 23, 2020
Contributor
ryanahamilton
left a comment
ryanahamilton
left a comment
There was a problem hiding this comment.
Nice improvement! Just a couple small comments.
Contributor
There was a problem hiding this comment.
This condition no longer persists (all circles are now clickable). Was that intentional? I don't see a strong case for why they needed to be conditional to begin with.
Contributor
Author
There was a problem hiding this comment.
I'm also not sure why we had this conditional. I'd be happy to restore it if you think it's useful.
Contributor
There was a problem hiding this comment.
No, I think we're good to omit.
The dags view uses onclick events for dagrun and taskinstance links. This breaks url previews, copying urls, opening links in a new tab, etc. This patch uses svg anchors with href attributes instead of onclick events so that these links behave like normal links.
jmcarp
force-pushed
the
jmcarp/dag-list-urls
branch
from
139ea99 to
9c81418
Compare
ryanahamilton
approved these changes
Nov 23, 2020
github-actions
bot
added
the
okay to merge
|
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dags view uses onclick events for dagrun and taskinstance links.
This breaks url previews, copying urls, opening links in a new tab, etc.
This patch uses svg anchors with href attributes instead of onclick
events so that these links behave like normal links.