Skip to content

Add 1.10.13 to CI, Breeze and Docs#12652

Merged
kaxil merged 2 commits into
apache:masterfrom
astronomer:update-docs-breeze
Nov 27, 2020
Merged

Add 1.10.13 to CI, Breeze and Docs#12652
kaxil merged 2 commits into
apache:masterfrom
astronomer:update-docs-breeze

Conversation

@kaxil
Copy link
Copy Markdown
Member

@kaxil kaxil commented Nov 27, 2020

This commit will allow users to install Airflow 1.10.13 via Breeze. Also updates docs


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions
Copy link
Copy Markdown
Contributor

The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Nov 27, 2020
Comment thread README.md
```bash
pip install apache-airflow==1.10.12 \
--constraint "https://raw.githubusercontent.com/apache/airflow/constraints-1.10.12/constraints-3.7.txt"
pip install apache-airflow==1.10.13 \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall line 117 in README to be updated as well? Similar to the change done in docs/installation.rst

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, in docs/production-deployment.rst, there are three sample Dockerfiles are using FROM apache/airflow:1.10.12. Should they be updated as well?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On phone so not adding comments at the exact code lines. Sorry for that

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L117 says that the change was introduced in 1.10.12 :) hence I have not changed that.

Updated the dockerfiles in docs/production-deployment.rst to use 1.10.13 in e6db852

Copy link
Copy Markdown
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions
Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

@kaxil kaxil merged commit 9a74ee5 into apache:master Nov 27, 2020
@kaxil kaxil deleted the update-docs-breeze branch November 27, 2020 13:35
potiuk pushed a commit that referenced this pull request Nov 29, 2020
@potiuk potiuk added this to the Airflow 1.10.14 milestone Nov 30, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 30, 2020
kaxil added a commit that referenced this pull request Dec 3, 2020
ashb pushed a commit that referenced this pull request Dec 3, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools full tests needed We need to run full set of tests for this PR to merge kind:documentation type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants