Skip to content

Allow switching xcom_pickling to JSON/Pickle#12724

Merged
kaxil merged 1 commit intoapache:masterfrom
astronomer:xcom-pickle
Dec 1, 2020
Merged

Allow switching xcom_pickling to JSON/Pickle#12724
kaxil merged 1 commit intoapache:masterfrom
astronomer:xcom-pickle

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Nov 30, 2020

Without this commit, the Webserver throws an error when
enabling xcom_pickling in the airflow_config by setting enable_xcom_pickling = True
(the default is False).

Example error:

>           return pickle.loads(result.value)
E           _pickle.UnpicklingError: invalid load key, '{'.

airflow/models/xcom.py:250: UnpicklingError
--------------------------------------------------

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Without this commit, the Webserver throws an error when
enabling xcom_pickling in the airflow_config by setting `enable_xcom_pickling = True`
(the default is `False`).

Example error:

```
>           return pickle.loads(result.value)
E           _pickle.UnpicklingError: invalid load key, '{'.

airflow/models/xcom.py:250: UnpicklingError
--------------------------------------------------
```
@kaxil kaxil added this to the Airflow 2.0.0 (rc1) milestone Nov 30, 2020
@kaxil kaxil requested a review from ashb November 30, 2020 23:49
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 1, 2020
@github-actions
Copy link

github-actions bot commented Dec 1, 2020

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil kaxil merged commit ac3a8bf into apache:master Dec 1, 2020
@kaxil kaxil deleted the xcom-pickle branch December 1, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants