Skip to content

Avoid log spam & have more meaningful log when pull image in DockerOperator #12763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XD-DENG merged 5 commits into from
Dec 3, 2020
Merged

Avoid log spam & have more meaningful log when pull image in DockerOperator #12763

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11c89a4
Avoid log spam & have more meaningful log when pull image in DockerOp…
XD-DENG Dec 2, 2020
b543036
Address for some lines having no 'id'
XD-DENG Dec 2, 2020
cdbb112
disable pylint too-many-nested-blocks
XD-DENG Dec 2, 2020
70e2bb7
Update airflow/providers/docker/operators/docker.py
XD-DENG Dec 2, 2020
23e81de
Address comment
XD-DENG Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion airflow/providers/docker/operators/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,13 +282,24 @@ def execute(self, context) -> Optional[str]:
raise Exception("The 'cli' should be initialized before!")

# Pull the docker image if `force_pull` is set or image does not exist locally
# pylint: disable=too-many-nested-blocks
if self.force_pull or not self.cli.images(name=self.image):
self.log.info('Pulling docker image %s', self.image)
latest_status = {}
for output in self.cli.pull(self.image, stream=True, decode=True):
if isinstance(output, str):
self.log.info("%s", output)
Comment thread
XD-DENG marked this conversation as resolved.
continue
if isinstance(output, dict) and 'status' in output:
self.log.info("%s", output['status'])
output_status = output["status"]
if 'id' not in output:
self.log.info("%s", output_status)
continue

output_id = output["id"]
if latest_status.get(output_id) != output_status:
self.log.info("%s: %s", output_id, output_status)
latest_status[output_id] = output_status

self.environment['AIRFLOW_TMP_DIR'] = self.tmp_dir
return self._run_image()
Expand Down