This table represents the list of all alembic revisions until 2.0.0 by ernest-kr · Pull Request #12792 · apache/airflow

ernest-kr · 2020-12-03T20:12:42Z

Created a table with the list of all alembic revisions until 2.0.0

Closes: #11989

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

boring-cyborg · 2020-12-03T20:12:45Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

mik-laj · 2020-12-03T20:34:22Z

@ernest-kr Do you think we can generate these tables automatically?

mik-laj · 2020-12-03T20:35:44Z

docs/apache-airflow/alembic_revisions.rst

This file wasn't added to the TOC. Am I right?

Hi @mik-laj , I have not checked if we can generate this table automatically. Since we display them in the logs , I think there could be a way to generate them.

This is not added yet to the table of contents.

I believe it is good to merge for RC1 as is @mik-laj -> we can automate it the first time we add a new migration. WDYT?

We can merge this now, but I don't find it difficult to automate the generation of these tables.
Code that gets the migration list:
https://github.com/sqlalchemy/alembic/blob/master/alembic/command.py
Custom directives that render templates based on jinja:
https://github.com/apache/airflow/blob/master/docs/exts/operators_and_hooks_ref.py#L176-L205 + tabulate with rst output

We need to have it tomorrow @ernest-kr -> do you think you can automate it ? BTW. You will also have to include #12890 when merged

Hi , Unfortunately I do not have time to finish by tomorrow on this. Can you create a new issue for the automate task so I can work on it?

No problem. Will do :)

potiuk · 2020-12-07T20:45:38Z

I think we need to exclude the doc from spell-check though @mik-laj @kaxil ? do you know how to do it ?

mik-laj · 2020-12-07T20:51:30Z

I think we need to exclude the doc from spell-check though @mik-laj @kaxil ? do you know how to do it ?

Why do you want to exclude this file? I guess identifiers should simply be written as a code literal and then they won't be checked by spell check.

mik-laj · 2020-12-07T20:51:48Z

docs/apache-airflow/alembic_revisions.rst

+     - Revises ID
+     - Airflow Version
+     - Summary
+   * - e3a246e0dc1


Suggested change

* - e3a246e0dc1

* - `e3a246e0dc1`

mik-laj · 2020-12-07T20:52:06Z

docs/apache-airflow/alembic_revisions.rst

+     - Airflow Version
+     - Summary
+   * - e3a246e0dc1
+     - 1507a7289a2f


Suggested change

- 1507a7289a2f

- `1507a7289a2f`

mik-laj · 2020-12-07T20:52:26Z

docs/apache-airflow/alembic_revisions.rst

+     - Summary
+   * - e3a246e0dc1
+     - 1507a7289a2f
+     - 2.0.0


Suggested change

- 2.0.0

- `2.0.0`

Did you want this to be a code literal, if so

Suggested change

- 2.0.0

- ``2.0.0``

mik-laj · 2020-12-07T20:52:56Z

docs/apache-airflow/alembic_revisions.rst

+   * - e3a246e0dc1
+     - 1507a7289a2f
+     - 2.0.0
+     - create is_encrypted


Suggested change

- create is_encrypted

- create `is_encrypted`

mik-laj · 2020-12-07T20:53:15Z

docs/apache-airflow/alembic_revisions.rst

+   * - bba5a7cfc896
+     - 1968acfc09e3
+     - 2.0.0
+     - add is_encrypted column to variable table


Suggested change

- add is_encrypted column to variable table

- add `is_encrypted` column to variable table

ashb · 2020-12-07T21:49:42Z

I think we need to exclude the doc from spell-check though @mik-laj @kaxil ? do you know how to do it ?

Why do you want to exclude this file? I guess identifiers should simply be written as a code literal and then they won't be checked by spell check.

There's a lot of identifiers.

ashb · 2020-12-07T21:51:03Z

docs/apache-airflow/alembic_revisions.rst

+The following table shows the list of alembic revisions
+
+
+.. list-table:: Alembic Revisions(until Airflow 2.0.0):


Is this just migrations since 1.10.14?

If so

Suggested change

.. list-table:: Alembic Revisions(until Airflow 2.0.0):

.. list-table:: Alembic Revisions (from Airflow 2.0.0 onwards):

Let me make these changes and modify my pull request

kaxil · 2020-12-07T21:53:32Z

The orders (and down_revision) have changed after #12896 was merged

kaxil · 2020-12-09T00:22:34Z

docs/apache-airflow/alembic_revisions.rst

+     - maintain history for compatibility with earlier migrations
+   * - 13eb55f81627
+     - 338e90f54d61
+     - 2.0.0


All the migrations have version 2.0.0 which is incorrect. If you check the example I have in #11989 -- we want to show which migration was added in which Version example 1.10.10, 1.10.12 etc

github-actions · 2021-02-28T00:30:14Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

boring-cyborg bot added the kind:documentation label Dec 3, 2020

mik-laj reviewed Dec 3, 2020

View reviewed changes

ernest-kr added 2 commits December 4, 2020 11:47

This table represents the list of all alembic revisions until 2.0.0

33af387

Added Header and the col widths and Modified TOC

880a159

ernest-kr force-pushed the alembic_revisions branch from 112f97f to 880a159 Compare December 4, 2020 19:53

potiuk added this to the Airflow 2.0.0rc1 milestone Dec 7, 2020

kaxil self-requested a review December 7, 2020 17:43

mik-laj reviewed Dec 7, 2020

View reviewed changes

ashb reviewed Dec 7, 2020

View reviewed changes

kaxil requested changes Dec 9, 2020

View reviewed changes

kaxil modified the milestones: Airflow 2.0.0rc1, Airflow 2.0 Dec 9, 2020

potiuk modified the milestones: Airflow 2.0, Airflow 2.0 clean-up Dec 17, 2020

github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 28, 2021

github-actions bot closed this Mar 5, 2021

	- add is_encrypted column to variable table
	- add `is_encrypted` column to variable table

		The following table shows the list of alembic revisions


		.. list-table:: Alembic Revisions(until Airflow 2.0.0):

	.. list-table:: Alembic Revisions(until Airflow 2.0.0):
	.. list-table:: Alembic Revisions (from Airflow 2.0.0 onwards):

Conversation

ernest-kr commented Dec 3, 2020

Uh oh!

boring-cyborg bot commented Dec 3, 2020

Uh oh!

mik-laj commented Dec 3, 2020

Uh oh!

mik-laj Dec 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

potiuk commented Dec 7, 2020

Uh oh!

mik-laj commented Dec 7, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashb commented Dec 7, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kaxil commented Dec 7, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

mik-laj Dec 3, 2020 •

edited

Loading