Skip to content

Add airflow __main__#12889

Closed
GuillaumeDesforges wants to merge 2 commits intoapache:v1-10-testfrom
GuillaumeDesforges:gdesforges/1.10.14rc4-fix-__main__
Closed

Add airflow __main__#12889
GuillaumeDesforges wants to merge 2 commits intoapache:v1-10-testfrom
GuillaumeDesforges:gdesforges/1.10.14rc4-fix-__main__

Conversation

@GuillaumeDesforges
Copy link

closes: #12888

This PR proposes to simply add a __main__.py file to airflow which is an exact copy of airflow/bin/airflow.

There is probably a better way to do it (see #7808 for versions 2.*+)

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always merge it to v1-10-test - then it will be released with the next release (there should be none, but you never know)!

@ashb
Copy link
Member

ashb commented Dec 7, 2020

We should change the airflow/bin/airflow to use this file instead of having code duplication.

@github-actions
Copy link

github-actions bot commented Dec 7, 2020

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 7, 2020
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

args = parser.parse_args()
args.func(args)
if __name__ == "__main__":
cli_main() No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure files have trailing new lines for consistency.

@github-actions
Copy link

github-actions bot commented Dec 7, 2020

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashb
Copy link
Member

ashb commented Jan 7, 2021

/opt/airflow/docs/_api/airflow/main/index.rst: WARNING: document isn't included in any toctree

We should exclude that file from the autoapi code generation.

@github-actions github-actions bot removed the full tests needed We need to run full set of tests for this PR to merge label Jan 7, 2021
@kaxil kaxil force-pushed the v1-10-test branch 3 times, most recently from dae8ca2 to 800e630 Compare January 22, 2021 21:30
@kaxil kaxil closed this Jan 30, 2021
@kaxil kaxil deleted the branch apache:v1-10-test January 30, 2021 20:33
@GuillaumeDesforges GuillaumeDesforges deleted the gdesforges/1.10.14rc4-fix-__main__ branch January 31, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments