Skip to content

Fix typo in setup.cfg#12935

Merged
XD-DENG merged 1 commit into
apache:masterfrom
astronomer:fixtyo-setupcfg
Dec 9, 2020
Merged

Fix typo in setup.cfg#12935
XD-DENG merged 1 commit into
apache:masterfrom
astronomer:fixtyo-setupcfg

Conversation

@kaxil
Copy link
Copy Markdown
Member

@kaxil kaxil commented Dec 9, 2020

airflow.api.connextion.openaip=*.yaml

to

airflow.api_connexion.openapi=*.yaml

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

```
airflow.api.connextion.openaip=*.yaml
```

to

```
airflow.api_connexion.openapi=*.yaml
```
@kaxil kaxil requested review from XD-DENG and ashb December 9, 2020 00:53
Copy link
Copy Markdown
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pylint problems from failing master?

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 9, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 9, 2020

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

Copy link
Copy Markdown
Member

@XD-DENG XD-DENG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this after Jarek's #12938 being merged

@XD-DENG XD-DENG merged commit 8d6840b into apache:master Dec 9, 2020
@ashb ashb deleted the fixtyo-setupcfg branch December 9, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants