Support google-cloud-datacatalog 3.0.0#13224
Conversation
09652de to
41ba0b2
Compare
There was a problem hiding this comment.
| from google.protobuf import field_mask_pb2 as field_mask # type: ignore | |
| from google.protobuf.field_mask_pb2 import FieldMask |
Should we keep it unified with import in other places?
There was a problem hiding this comment.
It just copied these lines from the Google library, but it will delete the alias, because it is not needed.
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
|
Can you please rebase to latest version @mik-laj ? We will likely need to check if it works as intended with upgrading to latest deps. |
9235af5 to
9c2f585
Compare
|
Strange. They seemed to pass in the PR. |
|
I did a rebase this morning. i also have all the fancy labels for this PR, but it seems me the problem may be with the constraints file that contains the old version. |
|
@mik-laj This is the error: |
This reverts commit feb8405.
Part of: #12116
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.