Skip to content

Add How-To guide for PostgresOperator#13281

Merged
kaxil merged 8 commits intoapache:masterfrom
astronomer:howto-guide-for-postgres-operator
Jan 6, 2021
Merged

Add How-To guide for PostgresOperator#13281
kaxil merged 8 commits intoapache:masterfrom
astronomer:howto-guide-for-postgres-operator

Conversation

@drdenzy
Copy link
Contributor

@drdenzy drdenzy commented Dec 23, 2020

It explores how to create tasks that interact with the PostgreSQL database.

This How-To guide demonstrates some of the best practices for using the PostgresOperator class.

closes: #11917


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice - few cosmetic coments, One question - is it possible to extract out some of the code examples and put it together as a fully-fetured example dag? We do that in other operators (look at the Google Howto Guides). This has the benefit that people can see a complete example in the example_dag as well as relevant snippets of code in the guide and navigate between them.

Also it would be great if such example dag is runnable as a System Test (https://github.com/apache/airflow/blob/master/TESTING.rst#airflow-system-tests) - we have not yet automated our system tests but we are planning to, It would be great to have such a runnable example_dag used here.

@kaxil kaxil changed the title This commit creates a How-To guide for PostgresOperator. Add How-To guide for PostgresOperator. Jan 4, 2021
@kaxil kaxil changed the title Add How-To guide for PostgresOperator. Add How-To guide for PostgresOperator Jan 4, 2021
@drdenzy drdenzy force-pushed the howto-guide-for-postgres-operator branch from 67538e3 to b3f8b43 Compare January 4, 2021 19:42
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@drdenzy drdenzy force-pushed the howto-guide-for-postgres-operator branch from b3f8b43 to 1bfc8d0 Compare January 5, 2021 20:33
@drdenzy drdenzy force-pushed the howto-guide-for-postgres-operator branch from ecf9f01 to 0f34671 Compare January 6, 2021 13:51
@drdenzy
Copy link
Contributor Author

drdenzy commented Jan 6, 2021

Thanks @kaxil for the well thought out suggestions. I have made the necessary changes in line with your suggestions.

@kaxil kaxil merged commit 9c75ea3 into apache:master Jan 6, 2021
@kaxil kaxil deleted the howto-guide-for-postgres-operator branch January 6, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add how-to Guide for Postgres operators

4 participants