Skip to content

Comments

Decode remote GCS logs with 'utf-8'#13304

Closed
astleychen wants to merge 1 commit intoapache:masterfrom
astleychen:decode-gcs-remote-log
Closed

Decode remote GCS logs with 'utf-8'#13304
astleychen wants to merge 1 commit intoapache:masterfrom
astleychen:decode-gcs-remote-log

Conversation

@astleychen
Copy link

Decode downloaded GCS logs with utf-8, otherwise, task logs would be viewed in one line without break.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:logging provider:google Google (including GCP) related issues labels Dec 24, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 24, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@astleychen
Copy link
Author

Dup of #13115.

@astleychen astleychen closed this Dec 24, 2020
@astleychen astleychen deleted the decode-gcs-remote-log branch January 29, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant