Skip to content

Comments

Fix typo in google cloud example dag#13321

Merged
potiuk merged 1 commit intoapache:masterfrom
smowden:patch-1
Dec 26, 2020
Merged

Fix typo in google cloud example dag#13321
potiuk merged 1 commit intoapache:masterfrom
smowden:patch-1

Conversation

@smowden
Copy link
Contributor

@smowden smowden commented Dec 26, 2020

False should not be passed as a string. It's correct in the other examples inside this file


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

False should not be passed as a string
@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Dec 26, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 26, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit f4745c8 into apache:master Dec 26, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 26, 2020

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants