Skip to content

Support google-cloud-tasks>=2.0.0#13334

Merged
mik-laj merged 4 commits intoapache:masterfrom
PolideaInternal:cloud-tasks-update
Dec 28, 2020
Merged

Support google-cloud-tasks>=2.0.0#13334
mik-laj merged 4 commits intoapache:masterfrom
PolideaInternal:cloud-tasks-update

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Dec 28, 2020

Part of: #12116


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@mik-laj mik-laj requested review from potiuk and turbaszek December 28, 2020 03:40
@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Dec 28, 2020
@mik-laj mik-laj changed the title Support google-cloud-tasks>=2.0.0 (#13117) Support google-cloud-tasks>=2.0.0 Dec 28, 2020
retry=retry,
timeout=timeout,
metadata=metadata,
metadata=metadata or (),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a strong opinion, but I think doing this before function invocation may increase readability, WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about that. For full readability this would require creating a new variable name, as modifying the parameter content may be ambiguous as some languages have special behavior. Luckily not in Python, but this can still arouse mixed feelings among polyglots, including mine. The new variable in this case would complicate the code unnecessarily.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 28, 2020
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@mik-laj mik-laj merged commit 1f71221 into apache:master Dec 28, 2020
@mik-laj mik-laj deleted the cloud-tasks-update branch December 28, 2020 10:29
potiuk added a commit to PolideaInternal/airflow that referenced this pull request Dec 28, 2020
turbaszek pushed a commit that referenced this pull request Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants