Support google-cloud-tasks>=2.0.0#13334
Conversation
787fc11 to
38d8a09
Compare
| retry=retry, | ||
| timeout=timeout, | ||
| metadata=metadata, | ||
| metadata=metadata or (), |
There was a problem hiding this comment.
Not a strong opinion, but I think doing this before function invocation may increase readability, WDYT?
There was a problem hiding this comment.
I am not sure about that. For full readability this would require creating a new variable name, as modifying the parameter content may be ambiguous as some languages have special behavior. Luckily not in Python, but this can still arouse mixed feelings among polyglots, including mine. The new variable in this case would complicate the code unnecessarily.
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
This reverts commit 1f71221.
Part of: #12116
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.