Skip to content

Comments

Fix environment checking for Pinot#13419

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:pinoot-check
Jan 1, 2021
Merged

Fix environment checking for Pinot#13419
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:pinoot-check

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Jan 1, 2021

In some cases, the validation of the environment may fail and end with the message below.

  /opt/airflow/scripts/in_container/check_environment.sh: line 41: -H 'accept: text/plain' | grep OK: syntax error: invalid arithmetic operator (error token is "'accept: text/plain' | grep OK")
  Presto (Broker API): .-----------------------------------------------------------------------------------------------

Unfortunately, Bash is not very obvious when it comes to multi-line text, and there is no type validation, so problems like this can happen.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions
Copy link

github-actions bot commented Jan 1, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jan 1, 2021
@potiuk potiuk merged commit 27c757d into apache:master Jan 1, 2021
@potiuk potiuk deleted the pinoot-check branch January 1, 2021 11:11
kaxil pushed a commit that referenced this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants