GitHub PROD image build is pushed to GitHub Registry.#13442
Merged
potiuk merged 1 commit intoapache:masterfrom Jan 4, 2021
Merged
GitHub PROD image build is pushed to GitHub Registry.#13442potiuk merged 1 commit intoapache:masterfrom
potiuk merged 1 commit intoapache:masterfrom
Conversation
potiuk
force-pushed
the
prod-build-image-pulled
branch
from
51d79d4 to
9cb7033
Compare
Member
Author
|
This fixes the final problem that none of the master builds succeeded recently. Pushing images to cache in master build failed because the PROD |
One of the earlier changes removed unneccessary pulling of the 'build' segment from GitHub Registry in `ci_wait_for_prod_image.sh'. It is not needed, because the K8S tests only use the final image and pulling the build image is not necessary. This has the undesired effect that 'ci_wait_for_prod_image.sh' was also used at the step where master image pushes the prod image to the repository as the 'latest' cache. In this case both - the 'final' prod image and the 'build' segment should be pulled, because both are needed for PROD image build optimizations.
potiuk
force-pushed
the
prod-build-image-pulled
branch
from
9cb7033 to
ae719a1
Compare
turbaszek
approved these changes
Jan 4, 2021
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
One of the earlier changes removed unneccessary pulling of the 'build' segment from GitHub Registry in `ci_wait_for_prod_image.sh'. It is not needed, because the K8S tests only use the final image and pulling the build image is not necessary. This has the undesired effect that 'ci_wait_for_prod_image.sh' was also used at the step where master image pushes the prod image to the repository as the 'latest' cache. In this case both - the 'final' prod image and the 'build' segment should be pulled, because both are needed for PROD image build optimizations. (cherry picked from commit 35e4a3b)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 23, 2021
One of the earlier changes removed unneccessary pulling of the 'build' segment from GitHub Registry in `ci_wait_for_prod_image.sh'. It is not needed, because the K8S tests only use the final image and pulling the build image is not necessary. This has the undesired effect that 'ci_wait_for_prod_image.sh' was also used at the step where master image pushes the prod image to the repository as the 'latest' cache. In this case both - the 'final' prod image and the 'build' segment should be pulled, because both are needed for PROD image build optimizations. (cherry picked from commit 35e4a3b) (cherry picked from commit 7a555ff)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the earlier changes removed unneccessary pulling of the
'build' segment from GitHub Registry in `ci_wait_for_prod_image.sh'.
It is not needed, because the K8S tests only use the final image
and pulling the build image is not necessary.
This has the undesired effect that 'ci_wait_for_prod_image.sh' was
also used at the step where master image pushes the prod image
to the repository as the 'latest' cache. In this case both - the
'final' prod image and the 'build' segment should be pulled,
because both are needed for PROD image build optimizations.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.