more specific error handling in undefined jinja variables rule#13549
Closed
lperson wants to merge 3 commits intoapache:v1-10-stablefrom
Closed
more specific error handling in undefined jinja variables rule#13549lperson wants to merge 3 commits intoapache:v1-10-stablefrom
lperson wants to merge 3 commits intoapache:v1-10-stablefrom
Conversation
lperson
commented
Jan 7, 2021
- Use regex to extract variable name from exception message
- Specific handling for ValueError and TypeError
- Defend against endless loop
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
Member
|
Caan you add tests to avoid regression? |
1e57476 to
121fbd5
Compare
c895fc4 to
a08cfba
Compare
RosterIn
reviewed
Feb 15, 2021
| "Task: templated_string, Attribute: env, Error: no such element: dict object['element']", | ||
| "Possible UndefinedJinjaVariable -> DAG: test-undefined-jinja-variables, " | ||
| "Task: miscellaneous_exception, Attribute: bash_command, " | ||
| "Error: 'NoneType' object is not iterable", |
Contributor
There was a problem hiding this comment.
Suggested change
| "Error: 'NoneType' object is not iterable", | |
| "Error: 'NoneType' object is not iterable, " |
Member
|
We removed this check in 1.2.0 of upgrade-check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.