Fix pod launcher role permissions to list events in chart #13649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the KubernetesPodOperator with log_events_on_failure=True, and the pod exits, the executor needs to access the events in the namespace. Before this resulted in an exception when using the chart as this it was not permitted by the pod-launcher role.
FloChehab
force-pushed
the
fix-chart-read-pod-events
branch
from
b226747 to
4cda531
Compare
Contributor
Author
|
Hello @kaxil, maybe you have time to review this PR? |
kaxil
approved these changes
Feb 10, 2021
danielhoherd
pushed a commit
to astronomer/airflow-chart
that referenced
this pull request
Mar 16, 2021
In order for the KubernetesExecutor to pick up tasks from dead schedulers, it needs to have the ability to patch existing pods s.t. the watcher thread can read the pod statuses. Add events list permissions <apache/airflow#13649>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, here is a small fix on the chart to prevent an airflow exception due to https://github.com/apache/airflow/blob/master/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py#L490.
I think adding a test for this is bit hard, but I am opened to suggestion.
More info:
When using the KubernetesPodOperator with
log_events_on_failure=True, and the pod exits,
the executor needs to access the events in the namespace.
Before this resulted in an exception when using the chart
as this it was not permitted by the pod-launcher role.