Fix and improve GCP BigTable hook and system test#13896
Merged
turbaszek merged 2 commits intoapache:masterfrom Jan 27, 2021
Merged
Fix and improve GCP BigTable hook and system test#13896turbaszek merged 2 commits intoapache:masterfrom
turbaszek merged 2 commits intoapache:masterfrom
Conversation
Improve environment variables in GCP BigTable system test It will help to parametrize system tests
boring-cyborg
bot
added
the
provider:google
Contributor
Author
|
cc: @mik-laj @turbaszek |
mik-laj
reviewed
Jan 25, 2021
| instance_labels=json.loads(CBT_INSTANCE_LABELS), | ||
| cluster_nodes=int(CBT_CLUSTER_NODES), | ||
| cluster_storage_type=int(CBT_CLUSTER_STORAGE_TYPE), | ||
| cluster_storage_type=int(int(CBT_CLUSTER_STORAGE_TYPE)), |
Contributor
Author
There was a problem hiding this comment.
Of course it is mistake. Thank you for pointing this out
turbaszek
approved these changes
Jan 27, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve environment variables in GCP BigTable system test
It will help to parametrize system tests
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.