Skip to content

Support list/add connections in the CLI#1394

Closed
jgao54 wants to merge 1 commit intoapache:masterfrom
jgao54:support-connection-via-cli
Closed

Support list/add connections in the CLI#1394
jgao54 wants to merge 1 commit intoapache:masterfrom
jgao54:support-connection-via-cli

Conversation

@jgao54
Copy link

@jgao54 jgao54 commented Apr 17, 2016

Dear Airflow Maintainers,

Please accept the following PR that

  • Add CLI support for listing/adding connections (I left out deleting/editing connections to keep it simple, but could be added in the future if there's a need for that).

Reminder to contributors:

  • You must add an Apache License header to all new files
  • Please squash your commits when possible and follow the 7 rules of good Git commits

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling f6c8a96 on jgao54:support-connection-via-cli into 7da6a94 on airbnb:master.

@jgao54 jgao54 force-pushed the support-connection-via-cli branch from f6c8a96 to 80b54b3 Compare April 17, 2016 19:03
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 80b54b3 on jgao54:support-connection-via-cli into 7da6a94 on airbnb:master.

@bolkedebruin
Copy link
Contributor

Please have a look at #1391 I'm not too happy with this kind of functionality directly inside the cli. Yes, this deviates from earlier, but the cli is getting hard to maintain and replicates functionality.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 67.218% when pulling 80b54b30c4976a61943dfa17a02d2a0429687628 on jgao54:support-connection-via-cli into 7da6a94 on airbnb:master.

@jgao54
Copy link
Author

jgao54 commented Apr 17, 2016

@bolkedebruin cool, all good points and glad to see the API support! I'll make changes accordingly once #1391 is merged.

@jgao54
Copy link
Author

jgao54 commented Apr 17, 2016

Closing for now.

@jgao54 jgao54 closed this Apr 17, 2016
@r39132 r39132 reopened this Apr 18, 2016
@r39132
Copy link
Contributor

r39132 commented Apr 18, 2016

@jgao54 @bolkedebruin No need to close this PR. We can always port it to the API model after the fact.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 67.086% when pulling 80b54b30c4976a61943dfa17a02d2a0429687628 on jgao54:support-connection-via-cli into 7da6a94 on airbnb:master.

@jgao54 jgao54 force-pushed the support-connection-via-cli branch from 80b54b3 to 6e4012b Compare April 19, 2016 01:27
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 6e4012b on jgao54:support-connection-via-cli into fcba070 on airbnb:master.

@jgao54 jgao54 force-pushed the support-connection-via-cli branch from 6e4012b to cd2ad30 Compare April 19, 2016 01:38
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling cd2ad30 on jgao54:support-connection-via-cli into fcba070 on airbnb:master.

@jgao54 jgao54 force-pushed the support-connection-via-cli branch from cd2ad30 to a29e0fd Compare April 19, 2016 02:14
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling a29e0fd on jgao54:support-connection-via-cli into fcba070 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 67.106% when pulling a29e0fd on jgao54:support-connection-via-cli into fcba070 on airbnb:master.

@bolkedebruin
Copy link
Contributor

@jgao54 @r39132 I'm not particularly against merging it now, just hoping that @jgao54 indeed ports the functionality to the API once it stabilizes a bit more ;-).

@jgao54
Copy link
Author

jgao54 commented Apr 19, 2016

@bolkedebruin most definitely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants