-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Adding support to use Glue Connections for Job correct subnet selection #14027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
a6931a5 to
352e60a
Compare
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
Hi again @dstandish, there was a weird error on build. It seems that had failed on Documentation style, but there are not any change on the PR. Could you check it out? How would I proceed? Thanks! |
|
you have a pre-commit hook failing: |
Hi, @dstandish . I've passed |
|
oh you might just need to rebase this was an issue briefly in master i think |
Hi @dstandish , It seems to be resolved after rebase. Thanks! ;) |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
|
Awesome work, congrats on your first merged pull request! |
Adding Connections parameter to AwsGlueJobHook in order to previse which subnet must be used for Job deployment.
If we have a Connection only accessible from an specific subnet (not the default one) and we do not pass this parameter, Job will be deployed to default subnet, so will not have access to DDBB, resulting in a Timeout error.
This small patch fix this issue based on Glue Client documentation.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.